Bug 70736

Summary: Web Inspector: print expired message count before remaining messages.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+, webkit.review.bot: commit-queue-

Description Pavel Feldman 2011-10-24 09:55:15 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-10-24 09:57:08 PDT
Created attachment 112205 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-24 10:36:35 PDT
Comment on attachment 112205 [details]
Patch

Attachment 112205 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10205587

New failing tests:
inspector/protocol/console-agent.html
Comment 3 Yury Semikhatsky 2011-10-24 10:48:12 PDT
Comment on attachment 112205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112205&action=review

> Source/WebCore/inspector/Inspector-0.1.json:387
> +                    { "name": "expiredMessagesCount", "type": "integer",  "optional": true, "description": "Number of messages dropped due to message threashold overflow." }

One extra space after comma in ',  "optional"'
Comment 4 Pavel Feldman 2011-10-25 01:23:33 PDT
Committed r98326: <http://trac.webkit.org/changeset/98326>