Bug 70728

Summary: [EFL] Add function to get geometry of focused element
Product: WebKit Reporter: Ivan Briano <ivan>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: g.czajkowski, gyuyoung.kim, leandro, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ivan Briano
Reported 2011-10-24 08:51:06 PDT
Add function to get geometry of focused element
Attachments
Patch (3.19 KB, patch)
2011-10-24 09:23 PDT, Ivan Briano 		no flags
DetailsFormatted DiffDiff
Patch (3.29 KB, patch)
2011-10-24 12:46 PDT, Ivan Briano 		no flags
DetailsFormatted DiffDiff
Patch (3.30 KB, patch)
2011-10-25 06:22 PDT, Ivan Briano 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ivan Briano
Comment 1 2011-10-24 09:23:46 PDT
Created attachment 112196 [details] Patch
Leandro Pereira
Comment 2 2011-10-24 12:38:00 PDT
Comment on attachment 112196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112196&action=review LGTM. > Source/WebKit/efl/ewk/ewk_frame.h:704 > + * Get the grometry, relative to the frame, of the focused element in the Please fix this typo before landing.
Ivan Briano
Comment 3 2011-10-24 12:46:28 PDT
Created attachment 112234 [details] Patch
Grzegorz Czajkowski
Comment 4 2011-10-24 23:36:19 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=112234&action=review > Source/WebKit/efl/ewk/ewk_frame.h:704 > + * Get the geometry, relative to the frame, of the focused element in the Please use "Gets". > Source/WebKit/efl/ewk/ewk_frame.h:708 > + * @param x pointer where to store the X value of the geometry. may be @c 0 Could you replace dot to comma here? there is no end of sentence. And please change below three lines too.
Ivan Briano
Comment 5 2011-10-25 06:22:25 PDT
Created attachment 112328 [details] Patch
Ivan Briano
Comment 6 2011-10-25 06:23:39 PDT
Patch updated based on comments and rebased.
Grzegorz Czajkowski
Comment 7 2011-10-25 06:36:00 PDT
LGTM
WebKit Review Bot
Comment 8 2011-10-25 12:44:34 PDT
Comment on attachment 112328 [details] Patch Clearing flags on attachment: 112328 Committed r98378: <http://trac.webkit.org/changeset/98378>
WebKit Review Bot
Comment 9 2011-10-25 12:44:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.