Bug 70726

Summary: Web Inspector: fix empty line handling in source maps.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Pavel Podivilov
Reported 2011-10-24 08:07:31 PDT
Web Inspector: fix empty line handling in source maps.
Attachments
Patch (4.56 KB, patch)
2011-10-24 08:08 PDT, Pavel Podivilov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-10-24 08:08:59 PDT
Created attachment 112186 [details] Patch
Yury Semikhatsky
Comment 2 2011-10-25 06:47:57 PDT
Comment on attachment 112186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112186&action=review > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:161 > + stringCharIterator.next(); I think you need to check hasNext() here and probably at line 156. > LayoutTests/inspector/debugger/compiler-source-mapping.html:81 > + "mappings":"AAAA;;;CACA", Add test for comma?
Pavel Podivilov
Comment 3 2011-10-25 07:26:15 PDT
Committed r98345: <http://trac.webkit.org/changeset/98345>
Note You need to log in before you can comment on or make changes to this bug.