Bug 70717

Summary: [GTK] Remove g_thread_init() calls
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, pnormand, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Updated patch none

Carlos Garcia Campos
Reported 2011-10-24 04:13:40 PDT
With newer glib it's not needed anymore and with previous versions it was already called by g_type_init().
Attachments
Patch (16.54 KB, patch)
2011-10-24 04:38 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch (16.57 KB, patch)
2011-10-24 06:51 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-10-24 04:38:17 PDT
Created attachment 112174 [details] Patch
WebKit Review Bot
Comment 2 2011-10-24 04:41:21 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Xan Lopez
Comment 3 2011-10-24 06:30:53 PDT
(In reply to comment #1) > Created an attachment (id=112174) [details] > Patch YFTR: - The MiniBrowser is not calling gtk_init right now, so this patch would be wrong as it is. We need to call gtk_init there (as we should have since day 0 anyway, it's a gtk app). - Calling g_thread_init very late in the game is only officially accepted since http://git.gnome.org/browse/glib/commit/?id=0df3ca8f9bbb624b219ecdb25d3fe8aa4a51d953. With this patch we'll rely an g_type_init doing it, as Carlos says.
Carlos Garcia Campos
Comment 4 2011-10-24 06:51:11 PDT
Created attachment 112180 [details] Updated patch Call gtk_init() in MiniBrowser main file.
Xan Lopez
Comment 5 2011-10-24 07:17:06 PDT
Comment on attachment 112180 [details] Updated patch LGTM.
Carlos Garcia Campos
Comment 6 2011-10-24 07:55:54 PDT
Committed r98239: <http://trac.webkit.org/changeset/98239>
Martin Robinson
Comment 7 2011-10-25 13:07:46 PDT
Comment on attachment 112180 [details] Updated patch Clearing review flag.
Note You need to log in before you can comment on or make changes to this bug.