Bug 70694

Summary: Web Inspector: Make CSS files load upon View demand; split inspector.css into views.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Patch] Split into 3, part 3.
none
[Patch] patch for landing none

Pavel Feldman
Reported 2011-10-23 07:34:37 PDT
Patch to follow.
Attachments
Patch (205.75 KB, patch)
2011-10-23 07:36 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] Split into 3, part 3. (155.58 KB, patch)
2011-10-23 08:51 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] patch for landing (155.60 KB, patch)
2011-10-24 02:57 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-10-23 07:36:45 PDT
Created attachment 112111 [details] Patch
Pavel Feldman
Comment 2 2011-10-23 07:38:57 PDT
I will split it into three patches for landing: 1) Make View lazy load CSS files 2) Convert DataGrid to View 3) Split CSS into multiple files But these are absolutely orthogonal, should not be uncomfortable to review. While only taken together I could test the functionality working properly.
WebKit Review Bot
Comment 3 2011-10-23 07:40:14 PDT
Comment on attachment 112111 [details] Patch Attachment 112111 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10205185
Early Warning System Bot
Comment 4 2011-10-23 07:43:28 PDT
Comment on attachment 112111 [details] Patch Attachment 112111 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10199466
Pavel Feldman
Comment 5 2011-10-23 08:51:48 PDT
Created attachment 112114 [details] [Patch] Split into 3, part 3.
Pavel Feldman
Comment 6 2011-10-24 02:57:37 PDT
Created attachment 112168 [details] [Patch] patch for landing
Pavel Feldman
Comment 7 2011-10-24 03:00:54 PDT
Committed r98228: <http://trac.webkit.org/changeset/98228>
Note You need to log in before you can comment on or make changes to this bug.