Summary: | [Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta type system. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zeno Albisser <zeno> | ||||||
Component: | WebKit Qt | Assignee: | Zeno Albisser <zeno> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 70315 | ||||||||
Attachments: |
|
Description
Zeno Albisser
2011-10-23 05:58:19 PDT
Created attachment 112109 [details]
patch for review.
is there a good reason why we should not do that?
Comment on attachment 112109 [details] patch for review. Yepp, this is the place we should do it. But it should be QML_DECLARE_TYPE(QTouchWebView), to get the pointer automatically and cover the list-usecase. http://doc.qt.nokia.com/4.7-snapshot/qdeclarativeengine.html#QML_DECLARE_TYPE Created attachment 112125 [details]
patch for review.
Comment on attachment 112125 [details]
patch for review.
r=me
Comment on attachment 112125 [details] patch for review. Clearing flags on attachment: 112125 Committed r98337: <http://trac.webkit.org/changeset/98337> All reviewed patches have been landed. Closing bug. |