Bug 70674

Summary: [WK2][GTK] Missing env variables cause WKTR to crash
Product: WebKit Reporter: Zan Dobersek <zan>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 69523    
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2011-10-22 03:03:33 PDT
Currently WebKitTestRunner will crash when running tests if TEST_RUNNER_INJECTED_BUNDLE_FILENAME and TEST_RUNNER_TEST_PLUGIN_PATH env variables are not set. While this can be avoided by manually exporting these it should really be done by the new-run-webkit-tests script. Patch on the way.
Attachments
Patch (2.03 KB, patch)
2011-10-22 03:46 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2011-10-22 03:46:57 PDT
Created attachment 112083 [details] Patch This patch sets the necessary variables and also fixes one inappropriate use of _build_path function.
WebKit Review Bot
Comment 2 2011-10-22 09:37:34 PDT
Comment on attachment 112083 [details] Patch Clearing flags on attachment: 112083 Committed r98193: <http://trac.webkit.org/changeset/98193>
WebKit Review Bot
Comment 3 2011-10-22 09:37:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.