Bug 70612

Summary: re-enable layout tests against chromium-mac-snowleopard (Skia) baselines
Product: WebKit Reporter: epoger
Component: Tools / TestsAssignee: epoger
Status: RESOLVED FIXED    
Severity: Normal CC: caryclark, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
Patch none

epoger
Reported 2011-10-21 08:59:12 PDT
Now that the chromium-mac (Skia) build is pretty stable and we have rebaselined all snowleopard images for it, we can stop ignoring all its layout test results.
Attachments
Patch (24.84 KB, patch)
2011-10-21 09:06 PDT, epoger 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
epoger
Comment 1 2011-10-21 09:06:20 PDT
Created attachment 111974 [details] Patch
epoger
Comment 2 2011-10-21 09:08:37 PDT
I have confirmed that layout tests pass on SnowLeopard without regression with this patch applied: - against both Skia and CG binaries - against both CPU and GPU tests
Cary Clark
Comment 3 2011-10-21 09:16:26 PDT
Comment on attachment 111974 [details] Patch LGTM
WebKit Review Bot
Comment 4 2011-10-21 10:38:44 PDT
Comment on attachment 111974 [details] Patch Clearing flags on attachment: 111974 Committed r98111: <http://trac.webkit.org/changeset/98111>
WebKit Review Bot
Comment 5 2011-10-21 10:38:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.