Bug 70612 - re-enable layout tests against chromium-mac-snowleopard (Skia) baselines
Summary: re-enable layout tests against chromium-mac-snowleopard (Skia) baselines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: epoger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-21 08:59 PDT by epoger
Modified: 2011-10-21 10:38 PDT (History)
2 users (show)

See Also:

Attachments
Patch (24.84 KB, patch)
2011-10-21 09:06 PDT, epoger 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description epoger 2011-10-21 08:59:12 PDT 
Now that the chromium-mac (Skia) build is pretty stable and we have rebaselined all snowleopard images for it, we can stop ignoring all its layout test results.
Comment 1 epoger 2011-10-21 09:06:20 PDT 
Created attachment 111974 [details]
Patch
Comment 2 epoger 2011-10-21 09:08:37 PDT 
I have confirmed that layout tests pass on SnowLeopard without regression with this patch applied:
- against both Skia and CG binaries
- against both CPU and GPU tests
Comment 3 Cary Clark 2011-10-21 09:16:26 PDT 
Comment on attachment 111974 [details]
Patch

LGTM
Comment 4 WebKit Review Bot 2011-10-21 10:38:44 PDT 
Comment on attachment 111974 [details]
Patch

Clearing flags on attachment: 111974

Committed r98111: <http://trac.webkit.org/changeset/98111>
Comment 5 WebKit Review Bot 2011-10-21 10:38:48 PDT 
All reviewed patches have been landed.  Closing bug.