Bug 70582

Summary: REGRESSION(r92480): Passing uninitialized variable in HTMLElement::calculateAndAdjustDirectionality()
Product: WebKit Reporter: Kent Tamura <tkent>
Component: DOMAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dglazkov, webkit.review.bot, yael
Priority: P1 Keywords: Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Kent Tamura 2011-10-20 22:33:08 PDT
void HTMLElement::calculateAndAdjustDirectionality()
{
    Node* strongDirectionalityTextNode;
    TextDirection textDirection = directionality(&strongDirectionalityTextNode);
    setHasDirAutoFlagRecursively(this, true, strongDirectionalityTextNode);

The variable strongDirectionalityTextNode is not initialized by directionality() in a specific situation, and it is passed to setHasDirAutoFlagRecursively().
Comment 1 Kent Tamura 2011-10-20 22:34:21 PDT
This was found by Valgrind.
http://code.google.com/p/chromium/issues/detail?id=100661
Comment 2 Kent Tamura 2011-10-20 22:36:38 PDT
Created attachment 111904 [details]
Patch
Comment 3 WebKit Review Bot 2011-10-22 03:52:51 PDT
Comment on attachment 111904 [details]
Patch

Clearing flags on attachment: 111904

Committed r98192: <http://trac.webkit.org/changeset/98192>
Comment 4 WebKit Review Bot 2011-10-22 03:52:56 PDT
All reviewed patches have been landed.  Closing bug.