Bug 70582

Summary: REGRESSION(r92480): Passing uninitialized variable in HTMLElement::calculateAndAdjustDirectionality()
Product: WebKit Reporter: Kent Tamura <tkent>
Component: DOMAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dglazkov, webkit.review.bot, yael
Priority: P1 Keywords: Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Kent Tamura
Reported 2011-10-20 22:33:08 PDT
void HTMLElement::calculateAndAdjustDirectionality() { Node* strongDirectionalityTextNode; TextDirection textDirection = directionality(&strongDirectionalityTextNode); setHasDirAutoFlagRecursively(this, true, strongDirectionalityTextNode); The variable strongDirectionalityTextNode is not initialized by directionality() in a specific situation, and it is passed to setHasDirAutoFlagRecursively().
Attachments
Patch (1.79 KB, patch)
2011-10-20 22:36 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2011-10-20 22:34:21 PDT
This was found by Valgrind. http://code.google.com/p/chromium/issues/detail?id=100661
Kent Tamura
Comment 2 2011-10-20 22:36:38 PDT
Created attachment 111904 [details] Patch
WebKit Review Bot
Comment 3 2011-10-22 03:52:51 PDT
Comment on attachment 111904 [details] Patch Clearing flags on attachment: 111904 Committed r98192: <http://trac.webkit.org/changeset/98192>
WebKit Review Bot
Comment 4 2011-10-22 03:52:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.