Bug 70550

Summary:

[Qt][WK2] qweberror* should follow the new file and class naming rules

Product:

WebKit

Reporter:

Jesus Sanchez-Palencia <jesus>

Component:

WebKit Qt

Assignee:

Jesus Sanchez-Palencia <jesus>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Qt, QtTriaged

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	noam: review+

Description Jesus Sanchez-Palencia 2011-10-20 15:07:13 PDT

QWebError is not following the new file and class naming rules and should be refactored.

Comment 1 Jesus Sanchez-Palencia 2011-10-20 15:07:34 PDT

(In reply to comment #0)
> QWebError is not following the new file and class naming rules and should be refactored.

The set of rules is defined at: https://trac.webkit.org/wiki/QtWebKitHacking

Comment 2 Jesus Sanchez-Palencia 2011-10-20 15:21:33 PDT

Created attachment 111855 [details]
Patch

Comment 3 Noam Rosenthal 2011-10-20 15:25:42 PDT

Comment on attachment 111855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111855&action=review

> Source/WebKit2/ChangeLog:9
> +        We have also merged QWebError and QWebErrorPrivate.

Nitpick: QWebErrorPrivate is now merged into QtWebError.

Comment 4 Jesus Sanchez-Palencia 2011-10-20 15:39:48 PDT

Committed r98030: <http://trac.webkit.org/changeset/98030>