Bug 70532 – [EFL] DRT: Allow choosing which backing store to use.

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Raphael Kubo da Costa (:rakuco)]

[EFL] DRT: Allow choosing which backing store to use.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 111818 [details]
Patch

[Antonio Gomes]

Comment on attachment 111818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111818&action=review

from IRC:

<tonikitoo> rakuco, what is a singlebackingstore approach? what is the normal approach? more than one backing store?

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:97
> +    static Ewk_View_Smart_Class api = EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION("DRT_View");

'api' as a variable name here sound a bit strange. could you elaborate?

[Antonio Gomes]

Comment on attachment 111818 [details]
Patch

after talking on IRC, r+, but I am not a fan of the naming used here. feel free to improve it according to your explaination bellow

<rakuco> tonikitoo: the efl port has two backing stores implemented in WebKit/efl/ewk. the single backing store just paints what's on the viewport, whereas the tiled one is similar to what exists in webcore (it predates the webcore implementation afaik). there's no normal approach (one has to choose which one to use in order to use the port), the patch makes it possible to run drt with different backing stores and check if the tests pass in both

[WebKit Review Bot]

Comment on attachment 111818 [details]
Patch

Clearing flags on attachment: 111818

Committed r99226: <http://trac.webkit.org/changeset/99226>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.