Summary: | Fixed Broken Build on some platforms that require return from non-void methods. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fady Samuel <fsamuel> | ||||||
Component: | New Bugs | Assignee: | Fady Samuel <fsamuel> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | epoger, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Fady Samuel
2011-10-20 11:40:04 PDT
Created attachment 111813 [details]
Patch
Created attachment 111814 [details]
Patch
Removed the no new tests line from the ChangeLog. Will this patch fix the Chromium "Webkit Mac10.5" builds, such as http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28CG%29 ? (In reply to comment #4) > Will this patch fix the Chromium "Webkit Mac10.5" builds, such as http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28CG%29 ? This looks like a different issue. This fixes Chromium OS builds. Comment on attachment 111814 [details] Patch Rejecting attachment 111814 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/MediaStreamTrack.cpp Hunk #1 FAILED at 58. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/MediaStreamTrack.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/10180570 |