Bug 70520 – [Qt][WK2] Remove redundant setPageIsVisible() API

• Component: New Bugs
• Status: RESOLVED FIXED

[alan]

[Qt][WK2] Remove redundant setPageIsVisible() API

[alan]

Created attachment 111798 [details]
Patch

[WebKit Review Bot]

Attachment 111798 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[alan]

Created attachment 111802 [details]
Patch

[alan]

Created attachment 112192 [details]
Patch

[Simon Hausmann]

Comment on attachment 112192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112192&action=review

r=me

> Source/WebKit2/UIProcess/DrawingAreaProxy.h:-80
> -    virtual void setPageIsVisible(bool isVisible) = 0;

I guess visibilityDidChange() could be made pure virtual now, as suggested in r76157

[alan]

as discussed on irc.

zalan: simon_: i think when tileddrawingarea gets thrashed would be the good time to review the pure virtual functions. there are a few more that can be cleaned up once the tiled class goes away
zalan: simon_: so that would be like one patch to fix the class design
zalan: simon_: but if you have strong opinion on this, i can do that now. i can go either way
simon_: no, you're right. might make more sense to do it all in one shot

[WebKit Review Bot]

Comment on attachment 112192 [details]
Patch

Clearing flags on attachment: 112192

Committed r98332: <http://trac.webkit.org/changeset/98332>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.