Bug 70498

Summary: [style] Allow usage of NULL in gst_*
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, levin, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
proposed patch
levin: review+
WebAudio GStreamer implementation: step 1 none

Philippe Normand
Reported 2011-10-20 06:36:52 PDT
Like in some other gst_ and g_ APIs.
Attachments
proposed patch (2.67 KB, patch)
2011-10-20 06:44 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
proposed patch (3.19 KB, patch)
2011-10-20 08:29 PDT, Philippe Normand 		levin: review+
DetailsFormatted DiffDiff
WebAudio GStreamer implementation: step 1 (38.49 KB, patch)
2011-10-20 08:50 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2011-10-20 06:44:04 PDT
Created attachment 111763 [details] proposed patch
David Levin
Comment 2 2011-10-20 07:47:22 PDT
Comment on attachment 111763 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=111763&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:2387 > + if search(r'\bgst_caps_new_full\b', line): It looks like there are a lot of gst_ exceptions here. Why not just allow \bgst_[a-z_]*\b and be done with it? :)
Philippe Normand
Comment 3 2011-10-20 08:23:02 PDT
All right, let's do this!
Philippe Normand
Comment 4 2011-10-20 08:29:02 PDT
Created attachment 111778 [details] proposed patch
Philippe Normand
Comment 5 2011-10-20 08:47:33 PDT
Committed r97983: <http://trac.webkit.org/changeset/97983>
Philippe Normand
Comment 6 2011-10-20 08:50:43 PDT
Created attachment 111781 [details] WebAudio GStreamer implementation: step 1
Philippe Normand
Comment 7 2011-10-20 08:53:12 PDT
Comment on attachment 111781 [details] WebAudio GStreamer implementation: step 1 Wrong bug
Note You need to log in before you can comment on or make changes to this bug.