Bug 70498 - [style] Allow usage of NULL in gst_*
Summary: [style] Allow usage of NULL in gst_*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-20 06:36 PDT by Philippe Normand
Modified: 2011-10-20 08:53 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (2.67 KB, patch)
2011-10-20 06:44 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
proposed patch (3.19 KB, patch)
2011-10-20 08:29 PDT, Philippe Normand 		levin: review+
Details | Formatted Diff | Diff
WebAudio GStreamer implementation: step 1 (38.49 KB, patch)
2011-10-20 08:50 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-10-20 06:36:52 PDT 
Like in some other gst_ and g_ APIs.
Comment 1 Philippe Normand 2011-10-20 06:44:04 PDT 
Created attachment 111763 [details]
proposed patch
Comment 2 David Levin 2011-10-20 07:47:22 PDT 
Comment on attachment 111763 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111763&action=review

> Tools/Scripts/webkitpy/style/checkers/cpp.py:2387
> +    if search(r'\bgst_caps_new_full\b', line):

It looks like there are a lot of gst_ exceptions here. Why not just allow \bgst_[a-z_]*\b and be done with it? :)
Comment 3 Philippe Normand 2011-10-20 08:23:02 PDT 
All right, let's do this!
Comment 4 Philippe Normand 2011-10-20 08:29:02 PDT 
Created attachment 111778 [details]
proposed patch
Comment 5 Philippe Normand 2011-10-20 08:47:33 PDT 
Committed r97983: <http://trac.webkit.org/changeset/97983>
Comment 6 Philippe Normand 2011-10-20 08:50:43 PDT 
Created attachment 111781 [details]
WebAudio GStreamer implementation: step 1
Comment 7 Philippe Normand 2011-10-20 08:53:12 PDT 
Comment on attachment 111781 [details]
WebAudio GStreamer implementation: step 1

Wrong bug