Bug 70494

Summary: [Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: laszlo.gombos, ossy
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Simon Hausmann
Reported 2011-10-20 05:29:48 PDT
We're using a bunch of the scene graph classes from QtDeclarative for our Qt 5 build. These classes will be renamed soon. This bug tracks the patch for adapt the WebKit2/Qt5 build.
Attachments
Patch (24.15 KB, patch)
2011-10-25 05:23 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch (30.50 KB, patch)
2011-10-27 06:10 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch for landing (32.38 KB, text/plain)
2011-10-28 01:12 PDT, Simon Hausmann 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2011-10-25 05:23:31 PDT
Created attachment 112324 [details] Patch
Simon Hausmann
Comment 2 2011-10-25 05:24:19 PDT
Comment on attachment 112324 [details] Patch Should not be landed with cq, but manually when the bot is updated.
Andreas Kling
Comment 3 2011-10-26 10:05:54 PDT
Comment on attachment 112324 [details] Patch LGTM.
Simon Hausmann
Comment 4 2011-10-27 06:10:45 PDT
Created attachment 112670 [details] Patch
Kenneth Rohde Christiansen
Comment 5 2011-10-27 06:12:50 PDT
Comment on attachment 112670 [details] Patch Looks good.
Simon Hausmann
Comment 6 2011-10-28 01:12:17 PDT
Created attachment 112829 [details] Patch for landing This is the right patch for landing (with the updatePaintNode hunk removed)
Csaba Osztrogonác
Comment 7 2011-10-28 06:14:00 PDT
Landed in http://trac.webkit.org/changeset/98721 and one more fix landed in http://trac.webkit.org/changeset/98722
Note You need to log in before you can comment on or make changes to this bug.