Bug 70469 – Document.cpp shouldn't need to know about every event for every feature

• Component: New Bugs
• Status: RESOLVED FIXED

[Adam Barth]

Document.cpp shouldn't need to know about every event for every feature

[Adam Barth]

Created attachment 111714 [details]
Patch

[Adam Barth]

Created attachment 111715 [details]
The generated file

[Eric Seidel (no email)]

Comment on attachment 111714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111714&action=review

LGTM.

> Source/WebCore/WebCore.gyp/scripts/action_makenames.py:120
> +        if inputBasename == 'make_names.pl' \
> +            or inputBasename == 'make_event_factory.pl':

Really?

> Source/WebCore/dom/EventFactory.h:38
> +    static PassRefPtr<Event> create(const String& eventType);

AtomicString?

[Adam Barth]

Yeah, I would have thought atomic string too, but that's not how the old code worked.

[Adam Barth]

Committed r97933: <http://trac.webkit.org/changeset/97933>

[Sam Weinig]

Looks like this probably changed the behavior for the TouchEvent interface when the RuntimeSwitch was off.  Was that intentional?  Do we care?

[Adam Barth]

Yeah, I decided I didn't care.  None of the other features work that way.

[Adam Barth]

I should have noted that in the ChangeLog.

[Sam Weinig]

(In reply to comment #8)
> I should have noted that in the ChangeLog.

Ok, just making sure.