Bug 70467

Summary: Optimization triggers in the old JIT may sometimes fire repeatedly even though there is no optimization to be done
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 69996    
Attachments:
Description Flags
the patch oliver: review+

Filip Pizlo
Reported 2011-10-19 19:49:57 PDT
If cti_optimize_from_ret fires but finds it has no work to do, it currently just returns. This means that it will fire again the next time even though there is still likely to be no work to do. This may cause slow downs since cti_optimize_from_ret is a stub call.
Attachments
the patch (2.08 KB, patch)
2011-10-19 20:43 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-10-19 20:43:05 PDT
Created attachment 111719 [details] the patch
Oliver Hunt
Comment 2 2011-10-19 20:46:26 PDT
Comment on attachment 111719 [details] the patch r=me
Filip Pizlo
Comment 3 2011-10-19 23:33:08 PDT
Landed in http://trac.webkit.org/changeset/97940
Note You need to log in before you can comment on or make changes to this bug.