Bug 70467 - Optimization triggers in the old JIT may sometimes fire repeatedly even though there is no optimization to be done
Summary: Optimization triggers in the old JIT may sometimes fire repeatedly even thoug...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 69996
  Show dependency tree / graph
 
Reported: 2011-10-19 19:49 PDT by Filip Pizlo
Modified: 2011-10-19 23:33 PDT (History)
0 users

See Also:

Attachments
the patch (2.08 KB, patch)
2011-10-19 20:43 PDT, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-10-19 19:49:57 PDT 
If cti_optimize_from_ret fires but finds it has no work to do, it currently just returns.  This means that it will fire again the next time even though there is still likely to be no work to do.  This may cause slow downs since cti_optimize_from_ret is a stub call.
Comment 1 Filip Pizlo 2011-10-19 20:43:05 PDT 
Created attachment 111719 [details]
the patch
Comment 2 Oliver Hunt 2011-10-19 20:46:26 PDT 
Comment on attachment 111719 [details]
the patch

r=me
Comment 3 Filip Pizlo 2011-10-19 23:33:08 PDT 
Landed in http://trac.webkit.org/changeset/97940