Bug 70455

Summary: [chromium/mac] Add support for building with make
Product: WebKit Reporter: Nico Weber <thakis>
Component: New BugsAssignee: Nico Weber <thakis>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Nico Weber
Reported 2011-10-19 16:53:09 PDT
[chromium/mac] Add support for building with make
Attachments
Patch (5.40 KB, patch)
2011-10-19 16:56 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (7.19 KB, patch)
2011-10-20 13:51 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (7.57 KB, patch)
2011-10-20 13:53 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.57 KB, patch)
2011-10-20 15:35 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2011-10-19 16:56:42 PDT
Created attachment 111696 [details] Patch
Nico Weber
Comment 2 2011-10-20 13:35:27 PDT
Comment on attachment 111696 [details] Patch needs tweaking
Nico Weber
Comment 3 2011-10-20 13:51:08 PDT
Created attachment 111841 [details] Patch
Nico Weber
Comment 4 2011-10-20 13:53:55 PDT
Created attachment 111843 [details] Patch
Nico Weber
Comment 5 2011-10-20 13:56:45 PDT
(Yesterday's clobber build time for chromium/mac was 23 min, today with clang on by default it's 18 min, and with this patch and make it's 12min on my machine)
Adam Barth
Comment 6 2011-10-20 14:08:34 PDT
Comment on attachment 111843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111843&action=review This is great. > Tools/Scripts/webkitdirs.pm:922 > + if (-e 'Makefile.chromium') { > + unless (-e 'Source/WebKit/chromium/WebKit.xcodeproj') { > + $hasUpToDateMakefile = 1; > + } else { > + $hasUpToDateMakefile = stat('Makefile.chromium')->mtime > stat('Source/WebKit/chromium/WebKit.xcodeproj')->mtime; > + } > + } four-space indent.
Nico Weber
Comment 7 2011-10-20 15:33:39 PDT
Comment on attachment 111843 [details] Patch argh misclicked
Nico Weber
Comment 8 2011-10-20 15:35:05 PDT
Created attachment 111857 [details] Patch for landing
WebKit Review Bot
Comment 9 2011-10-20 17:15:36 PDT
Comment on attachment 111857 [details] Patch for landing Clearing flags on attachment: 111857 Committed r98045: <http://trac.webkit.org/changeset/98045>
WebKit Review Bot
Comment 10 2011-10-20 17:15:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.