Summary: | Strip trailing whitespace in the WebCore/css C++ code | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexander Pavlov (apavlov) <apavlov> | ||||||||
Component: | CSS | Assignee: | Alexander Pavlov (apavlov) <apavlov> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric, macpherson, pfeldman, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alexander Pavlov (apavlov)
2011-10-19 05:12:26 PDT
Created attachment 111594 [details]
[PATCH] Suggested fix
Attachment 111594 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSStyleSelector.cpp:1625: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/css/CSSStyleSelector.cpp:2573: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/css/CSSStyleSelector.cpp:2580: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/css/CSSParser.cpp:5688: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/css/CSSParser.cpp:5715: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/css/MediaQueryExp.h:60: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5]
Total errors found: 7 in 90 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 111598 [details]
[PATCH] Multiline boolean expressions fixed where necessary to avoid style violations.
Attachment 111598 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 90 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 111599 [details]
[PATCH] Tab removed
Comment on attachment 111599 [details]
[PATCH] Tab removed
rs=me.
Committed r97854: <http://trac.webkit.org/changeset/97854> I'm surprised that such a far-reaching change was not announced (or discussed) on webkit-dev first. :( Way to break all my outstanding patches. Thanks guys. I would encourage you to use webkit-patch apply-attachment --non-interactive, or simply roll back to a revision before this change, apply your patch, and then let git rebase do the right thing. |