Bug 70410

Summary:

Strip trailing whitespace in the WebCore/css C++ code

Product:

WebKit

Reporter:

Alexander Pavlov (apavlov) <apavlov>

Component:

CSS

Assignee:

Alexander Pavlov (apavlov) <apavlov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, macpherson, pfeldman, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Suggested fix	none
[PATCH] Multiline boolean expressions fixed where necessary to avoid style violations.	none
[PATCH] Tab removed	krit: review+

Alexander Pavlov (apavlov)

Reported 2011-10-19 05:12:26 PDT

Patch to follow.

Attachments
[PATCH] Suggested fix (228.11 KB, patch) 2011-10-19 05:13 PDT, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
[PATCH] Multiline boolean expressions fixed where necessary to avoid style violations. (231.32 KB, patch) 2011-10-19 05:22 PDT, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
[PATCH] Tab removed (231.32 KB, patch) 2011-10-19 05:26 PDT, Alexander Pavlov (apavlov)	krit: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexander Pavlov (apavlov)

Comment 1 2011-10-19 05:13:59 PDT

Created attachment 111594 [details] [PATCH] Suggested fix

WebKit Review Bot

Comment 2 2011-10-19 05:17:35 PDT

Attachment 111594 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSStyleSelector.cpp:1625: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/css/CSSStyleSelector.cpp:2573: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/css/CSSStyleSelector.cpp:2580: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/css/CSSParser.cpp:5688: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/css/CSSParser.cpp:5715: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/css/MediaQueryExp.h:60: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] Total errors found: 7 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alexander Pavlov (apavlov)

Comment 3 2011-10-19 05:22:24 PDT

Created attachment 111598 [details] [PATCH] Multiline boolean expressions fixed where necessary to avoid style violations.

WebKit Review Bot

Comment 4 2011-10-19 05:25:56 PDT

Attachment 111598 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alexander Pavlov (apavlov)

Comment 5 2011-10-19 05:26:19 PDT

Created attachment 111599 [details] [PATCH] Tab removed

Dirk Schulze

Comment 6 2011-10-19 06:20:05 PDT

Comment on attachment 111599 [details] [PATCH] Tab removed rs=me.

Alexander Pavlov (apavlov)

Comment 7 2011-10-19 06:30:40 PDT

Committed r97854: <http://trac.webkit.org/changeset/97854>

Eric Seidel (no email)

Comment 8 2011-10-19 16:37:43 PDT

I'm surprised that such a far-reaching change was not announced (or discussed) on webkit-dev first. :(

Luke Macpherson

Comment 9 2011-10-19 16:42:33 PDT

Way to break all my outstanding patches. Thanks guys.

Eric Seidel (no email)

Comment 10 2011-10-19 16:47:32 PDT

I would encourage you to use webkit-patch apply-attachment --non-interactive, or simply roll back to a revision before this change, apply your patch, and then let git rebase do the right thing.

Note You need to log in before you can comment on or make changes to this bug.