Bug 70342

Summary:

Support percentage value for CSS property "-webkit-text-size-adjust"

Product:

WebKit

Reporter:

Chang Shu <cshu>

Component:

CSS

Assignee:

Chang Shu <cshu>

Status:

RESOLVED LATER

Severity:

Normal

CC:

ap, benm, darin, ddkilzer, eoconnor, hyatt, joepeck, kenneth, laszlo.gombos, macpherson, menard, mitz, parag, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

56543

Bug Blocks:

Attachments:

Description	Flags
Proposed Patch	cshu: review-, cshu: commit-queue-

Description Chang Shu 2011-10-18 11:03:55 PDT

WebKit trunk supports "auto" and "none"  as values for CSS property "-webkit-text-size-adjust". We should extend this to support percentage as it's supported on iOS and it's valuable to all user agents.

Comment 1 Chang Shu 2011-10-18 11:08:56 PDT

Some references copied from bug 56543.

=== Reference: ===
Apple Safari Developer Library:

<http://developer.apple.com/library/safari/documentation/appleapplications/reference/safariwebcontent/AdjustingtheTextSize/AdjustingtheTextSize.html#//apple_ref/doc/uid/TP40006510-SW16>

<http://developer.apple.com/library/safari/documentation/appleapplications/reference/SafariCSSRef/Articles/StandardCSSProperties.html#//apple_ref/doc/uid/TP30001266--webkit-text-size-adjust>

<http://css-infos.net/property/-webkit-text-size-adjust>

<http://www.campaignmonitor.com/blog/post/3339/save-your-layout-by-overriding-the-minimum-font-size-on-the-iphone-and/>

Comment 2 Simon Fraser (smfr) 2011-10-18 11:31:26 PDT

See also bug 56543.

Comment 3 Kenneth Rohde Christiansen 2011-10-19 02:05:58 PDT

You might want to have a look at these patches:

https://gitorious.org/+qtwebkit-webkit2-dev/webkit/qtwebkit-webkit2-dev/commit/d125b56f1b58cbf83b2e89ae129aed822e2f0961
https://gitorious.org/+qtwebkit-webkit2-dev/webkit/qtwebkit-webkit2-dev/commit/6e33150d62388afbf1389f01e052189ed36859e0
https://gitorious.org/+qtwebkit-webkit2-dev/webkit/qtwebkit-webkit2-dev/commit/74c0cc4c37a53bfade40aad40e422652902361b1

Comment 4 Parag Radke 2012-02-08 02:21:11 PST

Created attachment 126034 [details]
Proposed Patch

Patch to support percentage value for CSS property -webkit-text-size-adjust

Comment 5 Simon Fraser (smfr) 2012-02-08 02:29:20 PST

How can you fix this before bug 56543 is resolved?

Comment 6 Alexis Menard (darktears) 2012-02-08 03:47:58 PST

Comment on attachment 126034 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126034&action=review

> Source/WebCore/css/CSSParser.cpp:1993
> +                addProperty(CSSPropertyFontSize, createPrimitiveNumericValue(value), true);

Regardless what simon said, I don't see why you enforced the important parameter of addProperty.

Comment 7 Chang Shu 2012-02-13 01:48:35 PST

Comment on attachment 126034 [details]
Proposed Patch

Thanks for the patch. But I guess we want to hold off the implementation based on the comments from Simon.