Bug 70342

Summary:

Support percentage value for CSS property "-webkit-text-size-adjust"

Product:

WebKit

Reporter:

Chang Shu <cshu>

Component:

CSS

Assignee:

Chang Shu <cshu>

Status:

RESOLVED LATER

Severity:

Normal

CC:

ap, benm, darin, ddkilzer, eoconnor, hyatt, joepeck, kenneth, laszlo.gombos, macpherson, menard, mitz, parag, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

56543

Bug Blocks:

Attachments:

Description	Flags
Proposed Patch	cshu: review-, cshu: commit-queue-

Chang Shu

Reported 2011-10-18 11:03:55 PDT

WebKit trunk supports "auto" and "none" as values for CSS property "-webkit-text-size-adjust". We should extend this to support percentage as it's supported on iOS and it's valuable to all user agents.

Attachments
Proposed Patch (7.29 KB, patch) 2012-02-08 02:21 PST, Parag Radke	cshu: review- cshu: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chang Shu

Comment 1 2011-10-18 11:08:56 PDT

Some references copied from bug 56543. === Reference: === Apple Safari Developer Library: <http://developer.apple.com/library/safari/documentation/appleapplications/reference/safariwebcontent/AdjustingtheTextSize/AdjustingtheTextSize.html#//apple_ref/doc/uid/TP40006510-SW16> <http://developer.apple.com/library/safari/documentation/appleapplications/reference/SafariCSSRef/Articles/StandardCSSProperties.html#//apple_ref/doc/uid/TP30001266--webkit-text-size-adjust> <http://css-infos.net/property/-webkit-text-size-adjust> <http://www.campaignmonitor.com/blog/post/3339/save-your-layout-by-overriding-the-minimum-font-size-on-the-iphone-and/>

Simon Fraser (smfr)

Comment 2 2011-10-18 11:31:26 PDT

See also bug 56543.

Kenneth Rohde Christiansen

Comment 3 2011-10-19 02:05:58 PDT

You might want to have a look at these patches: https://gitorious.org/+qtwebkit-webkit2-dev/webkit/qtwebkit-webkit2-dev/commit/d125b56f1b58cbf83b2e89ae129aed822e2f0961 https://gitorious.org/+qtwebkit-webkit2-dev/webkit/qtwebkit-webkit2-dev/commit/6e33150d62388afbf1389f01e052189ed36859e0 https://gitorious.org/+qtwebkit-webkit2-dev/webkit/qtwebkit-webkit2-dev/commit/74c0cc4c37a53bfade40aad40e422652902361b1

Parag Radke

Comment 4 2012-02-08 02:21:11 PST

Created attachment 126034 [details] Proposed Patch Patch to support percentage value for CSS property -webkit-text-size-adjust

Simon Fraser (smfr)

Comment 5 2012-02-08 02:29:20 PST

How can you fix this before bug 56543 is resolved?

Alexis Menard (darktears)

Comment 6 2012-02-08 03:47:58 PST

Comment on attachment 126034 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126034&action=review > Source/WebCore/css/CSSParser.cpp:1993 > + addProperty(CSSPropertyFontSize, createPrimitiveNumericValue(value), true); Regardless what simon said, I don't see why you enforced the important parameter of addProperty.

Chang Shu

Comment 7 2012-02-13 01:48:35 PST

Comment on attachment 126034 [details] Proposed Patch Thanks for the patch. But I guess we want to hold off the implementation based on the comments from Simon.

Note You need to log in before you can comment on or make changes to this bug.