Bug 70340 – Crash in WebProcess at com.apple.AppKit: -[NSFilePromiseDragSource draggedImage:endedAt:operation:] + 101

• Component: HTML Editing
• Status: RESOLVED FIXED

[Enrica Casucci]

AppKit is not retaining the dragging source. This seems to lead to crashes under some unknown circumstances.

[Enrica Casucci]

Created attachment 111468 [details]
patch

[Darin Adler]

Comment on attachment 111468 [details]
patch

OK, lets give this a try.

Comment on attachment 111468 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111468&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:61
>  @interface NSFilePromiseDragSource : NSObject
>  {
> +    id _dragSource;

Must we use this extra knowledge about NSFilePromise’s ivar layout (and assign to this ivar)? Couldn’t we have added this as an ivar to WKPasteboardFilePromiseOwner? Perhaps this doesn’t matter in the Objective-C runtime used for WebKit2?

[Darin Adler]

(In reply to comment #3)
> Must we use this extra knowledge about NSFilePromise’s ivar layout (and assign to this ivar)?

No, we don’t have to.

> Couldn’t we have added this as an ivar to WKPasteboardFilePromiseOwner?

Yes, we could have done that instead. Enrica and I discussed that option.

> Perhaps this doesn’t matter in the Objective-C runtime used for WebKit2?

That doesn’t sound right to me. I’m not even sure how that would work.

[Enrica Casucci]

Committed revision 97808.