Bug 70314

Summary: Prepare SVGImage intrinsic size negotiation: Add intrinsic size & ratio calculation functionality to Image
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: japhet, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 47156    
Attachments:
Description Flags
Patch none

Description Nikolas Zimmermann 2011-10-18 01:15:36 PDT
Add a "void computeIntrinsicDimension(Length& intrinsicWidth, Lengt& intrinsicHeight, FloatSize& intrinsicRatio)" helper method to Image/GeneratedImage/SVGImage and make it accessible through StyleImage.
This splits off some parts of bug 47156 into a smaller piece.
Comment 1 Nikolas Zimmermann 2011-10-18 01:23:37 PDT
Created attachment 111408 [details]
Patch

Split-off another chunk from bug 47156, to aid reducing the total patch size.
Comment 2 Antti Koivisto 2011-10-18 01:32:17 PDT
Comment on attachment 111408 [details]
Patch

r=me
Comment 3 Nikolas Zimmermann 2011-10-18 01:33:32 PDT
Oops ; missing in one line in SVGImage.cpp - manual merging sucks..
I'll make sure it builds before landing :-)
Comment 4 Early Warning System Bot 2011-10-18 01:34:20 PDT
Comment on attachment 111408 [details]
Patch

Attachment 111408 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10125167
Comment 5 Gyuyoung Kim 2011-10-18 01:38:09 PDT
Comment on attachment 111408 [details]
Patch

Attachment 111408 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10126163
Comment 6 Nikolas Zimmermann 2011-10-18 01:38:48 PDT
Landed in r97727.