Bug 70309

Summary: [EFL][WK2] Fix compilation error by include WebErrors.h file.
Product: WebKit Reporter: Tomasz Morawski <t.morawski>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch
none
Patch 2
none
Patch 3
none
Patch 4 none

Tomasz Morawski
Reported 2011-10-17 23:32:44 PDT
Added a header file to fix compilation error.
Attachments
Patch (1.15 KB, patch)
2011-10-17 23:36 PDT, Tomasz Morawski 		no flags
DetailsFormatted DiffDiff
Patch 2 (1.14 KB, patch)
2011-10-18 00:46 PDT, Tomasz Morawski 		no flags
DetailsFormatted DiffDiff
Patch 3 (1.14 KB, patch)
2011-10-18 01:17 PDT, Tomasz Morawski 		no flags
DetailsFormatted DiffDiff
Patch 4 (1.12 KB, patch)
2011-10-18 01:26 PDT, Tomasz Morawski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Tomasz Morawski
Comment 1 2011-10-17 23:36:36 PDT
Created attachment 111391 [details] Patch
Gyuyoung Kim
Comment 2 2011-10-18 00:28:56 PDT
Comment on attachment 111391 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111391&action=review > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:27 > + It seems to me this is unneeded line. According to webkit coding style guideline, there is no an empty line below config.h http://www.webkit.org/coding/coding-style.html
Tomasz Morawski
Comment 3 2011-10-18 00:46:16 PDT
Created attachment 111403 [details] Patch 2
Gyuyoung Kim
Comment 4 2011-10-18 01:06:02 PDT
Comment on attachment 111403 [details] Patch 2 Why do you use <WebCore/ResourceErrror.h>? EFL build script includes WebCore directory as include directory ? It looks other ports use <WebCore/ResourceError.h> BTW, If this patch is to fix build break, committer can land this patch to fix build break. Could you modify ChangeLog again as below? For example, *Unreviewd build fix* instead of *Reviewed by NOBODY (OOPS!).* Then, only request cq?, not r?
Gyuyoung Kim
Comment 5 2011-10-18 01:07:07 PDT
(In reply to comment #4) > (From update of attachment 111403 [details]) > Why do you use <WebCore/ResourceErrror.h>? I mean why not you don't use <WebCore/ResourceError.h>.
Tomasz Morawski
Comment 6 2011-10-18 01:17:07 PDT
Created attachment 111407 [details] Patch 3
Tomasz Morawski
Comment 7 2011-10-18 01:20:42 PDT
> EFL build script includes WebCore directory as include directory ? > I mean why not you don't use <WebCore/ResourceError.h>. Yes, it is included and this code can be compiled. But I have changed it to follow other port. Thank you and I am sorry for that.
Tomasz Morawski
Comment 8 2011-10-18 01:26:36 PDT
Created attachment 111409 [details] Patch 4
WebKit Review Bot
Comment 9 2011-10-18 04:51:43 PDT
Comment on attachment 111409 [details] Patch 4 Clearing flags on attachment: 111409 Committed r97739: <http://trac.webkit.org/changeset/97739>
WebKit Review Bot
Comment 10 2011-10-18 04:51:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.