Bug 70294

Summary:

platform/chromium/compositing/plugins/webplugin* failing on cg snowleopard

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

Platform

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alokp, dglazkov, jamesr

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.6

Attachments:

Description	Flags
Patch	none

Dirk Pranke

Reported 2011-10-17 18:47:49 PDT

The new tests added in http://trac.webkit.org/changeset/97678 (bug 69027) are failing in the CG Snow Leopard GPU path. We don't seem to have a chromium-gpu-cg-macsnowleopard directory, so I'll assume any baselines should go into chromium-gpu-cg-mac . It looks like they just need new baselines, but I'm filing this in case I am mistaken. Also, for some reason, rebaseline-chromium-webkit-tests doesn't seem to be handling the archives properly (need to dig into this further).

Attachments
Patch (3.42 KB, patch) 2011-10-17 18:57 PDT, Dirk Pranke	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2011-10-17 18:57:27 PDT

Created attachment 111368 [details] Patch

Dirk Pranke

Comment 2 2011-10-17 19:02:04 PDT

Committed r97699: <http://trac.webkit.org/changeset/97699>

Alok Priyadarshi

Comment 3 2011-10-18 09:54:19 PDT

There are TEXT differences. RenderBody height differs by one pixel. Is this expected?

Dirk Pranke

Comment 4 2011-10-18 19:05:09 PDT

Good question. I don't know. It was your change, though, so you tell me ...

Eric Seidel (no email)

Comment 5 2011-12-19 11:12:50 PST

Comment on attachment 111368 [details] Patch Cleared review? from attachment 111368 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

Note You need to log in before you can comment on or make changes to this bug.