Bug 70281

Summary: Rename static put to putByIndex
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67690    
Attachments:
Description Flags
Patch none

Mark Hahnenberg
Reported 2011-10-17 16:06:17 PDT
There are two versions of put, one that uses an Identifier and the other that uses an unsigned. We need to rename the version that takes an unsigned to putByIndex. This is in preparation for adding both versions to the MethodTable.
Attachments
Patch (22.97 KB, patch)
2011-10-17 16:10 PDT, Mark Hahnenberg
no flags
Mark Hahnenberg
Comment 1 2011-10-17 16:10:15 PDT
WebKit Review Bot
Comment 2 2011-10-17 16:12:14 PDT
Attachment 111340 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource M LayoutTests/platform/chromium/test_expectations.txt M LayoutTests/ChangeLog r97663 = 5dde0580a24b0fb1bb50d10ae91b5d1b3cc66d66 (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2011-10-18 15:50:35 PDT
Comment on attachment 111340 [details] Patch r=me
WebKit Review Bot
Comment 4 2011-10-18 16:52:51 PDT
Comment on attachment 111340 [details] Patch Clearing flags on attachment: 111340 Committed r97817: <http://trac.webkit.org/changeset/97817>
WebKit Review Bot
Comment 5 2011-10-18 16:52:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.