Bug 70254 – [Qt] Support WK1-only Skipped list

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Chang Shu]

As the development of new features may focus on WK2 only, some layout tests may work on WK2 but fail on WK1. Currently, all skipped WK1 tests are also skipped on WK2. We should create a mechanism to allow tests skip on WK1 but run on WK2.

[Chang Shu]

Created attachment 111295 [details]
patch 1

We don't seem have to implement any code for baseline results at the moment.

[WebKit Review Bot]

Attachment 111295 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chang Shu]

Created attachment 111311 [details]
patch 2

add ORWT support

[WebKit Review Bot]

Attachment 111311 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Csaba Osztrogonác]

Comment on attachment 111311 [details]
patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=111311&action=review

> Tools/Scripts/old-run-webkit-tests:2478
> +    # Add Qt WK1-only skipped tests.
> +    push(@skippedFileDirectories, catdir($platformBaseDirectory, "qt-wk1")) if ($platform eq "qt-linux");

I think (isQt() && !$useWebKitTestRunner) condition would be better than ($platform eq "qt-linux"),
but I'm not sure if isQt() is absolutely correct now.

[Chang Shu]

Created attachment 111436 [details]
patch 3: update per review

[Csaba Osztrogonác]

Comment on attachment 111436 [details]
patch 3: update per review

LGTM, r=me, but cq-, because commit queue still hates me.
Please watch the bots and roll-out if something goes wrong.

[Chang Shu]

Comment on attachment 111436 [details]
patch 3: update per review

Clearing flags on attachment: 111436

Committed r97866: <http://trac.webkit.org/changeset/97866>

[Chang Shu]

All reviewed patches have been landed.  Closing bug.