AX: children() method should be consolidated in AccessibilityObject

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

Right now there are four or five nearly identical implementations of children(). 

Those can be consolidate into one method in AccessibilityObject

[chris fleizach]

Created attachment 111270 [details]
patch

[WebKit Review Bot]

Attachment 111270 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 111270 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111270&action=review

> Source/WebCore/accessibility/AccessibilityTableColumn.cpp:75
> + 

Stray blank space on what should just be an empty line.

[chris fleizach]

http://trac.webkit.org/changeset/97629