Bug 70226

Summary: CSS/XSLStyleSheet: Remove insert() and remove().
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch koivisto: review+

Andreas Kling
Reported 2011-10-17 03:43:36 PDT
These methods are internal to WebKit and not part of the CSSOM.
Attachments
Proposed patch (5.03 KB, patch)
2011-10-17 03:44 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-10-17 03:44:47 PDT
Created attachment 111240 [details] Proposed patch
Kenneth Rohde Christiansen
Comment 2 2011-10-17 03:47:09 PDT
Comment on attachment 111240 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=111240&action=review > Source/WebCore/ChangeLog:7 > + Reviewed by NOBODY (OOPS!). > + shouldn't you add some reasoning for the change?
Antti Koivisto
Comment 3 2011-10-17 03:54:53 PDT
Comment on attachment 111240 [details] Proposed patch r=me, with changes discussed in irc: Keep remove() so you don't need to use the external api functions for internal stuff.
Andreas Kling
Comment 4 2011-10-17 04:38:06 PDT
Committed r97605: <http://trac.webkit.org/changeset/97605>
Note You need to log in before you can comment on or make changes to this bug.