Bug 70226

Summary:

CSS/XSLStyleSheet: Remove insert() and remove().

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

CSS

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	koivisto: review+

Description Andreas Kling 2011-10-17 03:43:36 PDT

These methods are internal to WebKit and not part of the CSSOM.

Comment 1 Andreas Kling 2011-10-17 03:44:47 PDT

Created attachment 111240 [details]
Proposed patch

Comment 2 Kenneth Rohde Christiansen 2011-10-17 03:47:09 PDT

Comment on attachment 111240 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111240&action=review

> Source/WebCore/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).
> +

shouldn't you add some reasoning for the change?

Comment 3 Antti Koivisto 2011-10-17 03:54:53 PDT

Comment on attachment 111240 [details]
Proposed patch

r=me, with changes discussed in irc:

Keep remove() so you don't need to use the external api functions for internal stuff.

Comment 4 Andreas Kling 2011-10-17 04:38:06 PDT

Committed r97605: <http://trac.webkit.org/changeset/97605>