Bug 70220

Summary: Remove OptionGroupElement
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Minor CC: darin, rniwa, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch 2
none
Patch for landing none

Kent Tamura
Reported 2011-10-17 01:28:40 PDT
Remove OptionGroupElement
Attachments
Patch (21.48 KB, patch)
2011-10-17 01:35 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (22.14 KB, patch)
2011-10-17 01:45 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch for landing (22.57 KB, patch)
2011-10-17 21:05 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2011-10-17 01:35:06 PDT
Created attachment 111224 [details] Patch
Collabora GTK+ EWS bot
Comment 2 2011-10-17 01:38:13 PDT
Comment on attachment 111224 [details] Patch Attachment 111224 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10079784
Kent Tamura
Comment 3 2011-10-17 01:45:50 PDT
Created attachment 111225 [details] Patch 2 GTK build fix
Darin Adler
Comment 4 2011-10-17 10:16:09 PDT
Comment on attachment 111225 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=111225&action=review > Source/WebCore/dom/OptionElement.cpp:112 > + if (parentElement && isHTMLOptGroupElement(parentElement)) I’m not sure we should have a special function for this. Just doing hasTagName(optgroupTag) directly seems fine to me. > Source/WebCore/html/HTMLOptGroupElement.cpp:147 > + return node && node->isHTMLElement() && node->hasTagName(optgroupTag); There is no need for the isHTMLElement check in this function. The hasTagName function already checks the namespace and will return false for non-HTMLElement. > Source/WebCore/html/HTMLOptGroupElement.h:64 > +bool isHTMLOptGroupElement(const Node*); As I said above, I am not sure we need a helper function. It’s the same thing as calling hasTagName(optgroupTag).
Kent Tamura
Comment 5 2011-10-17 21:01:17 PDT
Thank you for reviewing. Ok, I'll remove isHTMLOptGroupElement(), and land it.
Kent Tamura
Comment 6 2011-10-17 21:05:55 PDT
Created attachment 111374 [details] Patch for landing
WebKit Review Bot
Comment 7 2011-10-17 22:38:43 PDT
Comment on attachment 111374 [details] Patch for landing Clearing flags on attachment: 111374 Committed r97720: <http://trac.webkit.org/changeset/97720>
WebKit Review Bot
Comment 8 2011-10-17 22:38:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.