Bug 70180

Summary: [GTK] GtkAdjustment watcher updates adjustments too lazily
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68757    
Attachments:
Description Flags
Patch none

Description Martin Robinson 2011-10-15 14:05:27 PDT 
The timeout  GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater has a low enough priority that sometimes scrollbars become out of sync with the page contents. I've seen this cause drawing artifacts as well. We just need to boost the priority slightly.
Comment 1 Martin Robinson 2011-10-15 14:11:00 PDT 
Created attachment 111144 [details]
Patch
Comment 2 Carlos Garcia Campos 2011-10-16 23:45:52 PDT 
Comment on attachment 111144 [details]
Patch

LGTM
Comment 3 Gustavo Noronha (kov) 2011-10-24 05:45:33 PDT 
Comment on attachment 111144 [details]
Patch

I hate these priority problems =( I think it makes sense as it is, but just out of curiosity, did you try having it set to something like G_PRIORITY_HIGH_IDLE itself, which would guarantee it's ran before any GTK+ layout is performed?
Comment 4 Martin Robinson 2011-10-25 09:38:33 PDT 
Comment on attachment 111144 [details]
Patch

Landing this now, since I think Alex wants it for the release. To answer kov's question, I'm pretty sure I did test G_PRIORITY_HIGH_IDLE without much luck.
Comment 5 WebKit Review Bot 2011-10-25 09:51:57 PDT 
Comment on attachment 111144 [details]
Patch

Clearing flags on attachment: 111144

Committed r98352: <http://trac.webkit.org/changeset/98352>
Comment 6 WebKit Review Bot 2011-10-25 09:52:02 PDT 
All reviewed patches have been landed.  Closing bug.