Bug 70163

Summary: Add getConstructData to the MethodTable
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67690    
Attachments:
Description Flags
Patch
none
Patch none

Mark Hahnenberg
Reported 2011-10-14 17:53:46 PDT
We now need to add getConstructData to the MethodTable in ClassInfo in preparation for removing the virtual version of getConstructData.
Attachments
Patch (4.33 KB, patch)
2011-10-17 15:47 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (5.43 KB, patch)
2011-10-18 10:57 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-10-17 15:47:01 PDT
Created attachment 111335 [details] Patch
WebKit Review Bot
Comment 2 2011-10-17 15:48:58 PDT
Attachment 111335 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Hahnenberg
Comment 3 2011-10-18 10:57:12 PDT
Created attachment 111470 [details] Patch
Geoffrey Garen
Comment 4 2011-10-19 14:31:51 PDT
Comment on attachment 111470 [details] Patch r=me
WebKit Review Bot
Comment 5 2011-10-19 16:26:55 PDT
Comment on attachment 111470 [details] Patch Clearing flags on attachment: 111470 Committed r97892: <http://trac.webkit.org/changeset/97892>
WebKit Review Bot
Comment 6 2011-10-19 16:26:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.