| Summary: | watchlist: Add a validation check for the email names in the list. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Levin <levin> | ||||
| Component: | New Bugs | Assignee: | David Levin <levin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, levin+watchlist, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
David Levin
2011-10-14 15:53:47 PDT
Created attachment 111102 [details]
Patch
Comment on attachment 111102 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111102&action=review > Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:137 > + raise Exception("The email alias %s which is in the watchlist is not listed as a contributor in committers.py" % email) I see that we've already using Exception in this class, but it's usually good form to use a subclass of exception so that folks can catch these parse errors without catching all manner of exceptions. (Just a general note. Nothing that needs to be addressed now.) Committed as http://trac.webkit.org/changeset/97530 |