Bug 70131

Summary: [Qt] Enable fullscreen api on Qt
Product: WebKit Reporter: Chang Shu <cshu>
Component: New BugsAssignee: Chang Shu <cshu>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, laszlo.gombos, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70111, 70132    
Attachments:
Description Flags
patch 1 none

Chang Shu
Reported 2011-10-14 12:12:42 PDT
The feature was partially compiled because of flaw in features.pri.
Attachments
patch 1 (5.26 KB, patch)
2011-10-14 12:22 PDT, Chang Shu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 2011-10-14 12:22:00 PDT
Created attachment 111048 [details] patch 1
WebKit Review Bot
Comment 2 2011-10-14 15:16:54 PDT
Comment on attachment 111048 [details] patch 1 Clearing flags on attachment: 111048 Committed r97518: <http://trac.webkit.org/changeset/97518>
WebKit Review Bot
Comment 3 2011-10-14 15:16:59 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 4 2011-10-19 05:07:42 PDT
Hmm, why do we enable this compile flag when we don't actually implement support for it?
Chang Shu
Comment 5 2011-10-19 06:02:21 PDT
(In reply to comment #4) > Hmm, why do we enable this compile flag when we don't actually implement support for it? Before the patch, the flag was partially enabled: ENABLE_FULLSCREEN_API was set to 1 but FEATURE_DEFINES_JAVASCRIPT was not set properly. It looked more like a bug to me than something did intentionally. We should either remove them completely or finish the rest of the support.
Simon Hausmann
Comment 6 2011-10-19 06:07:58 PDT
I think your patch was good because it fixed that inconsistency (between the build flags and the idl generator defines). But perhaps we should change the default to be false. What do you think?
Chang Shu
Comment 7 2011-10-19 06:35:01 PDT
(In reply to comment #6) > I think your patch was good because it fixed that inconsistency (between the build flags and the idl generator defines). But perhaps we should change the default to be false. What do you think? That makes sense. I may not be able to continue this effort in the short term. I will provide a patch to disable them.
Note You need to log in before you can comment on or make changes to this bug.