Bug 70119

Summary: Plumb style-checker filter up to command options and make land-cowboy use it.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: Tools / TestsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70143    
Attachments:
Description Flags
Patch abarth: review+

Dimitri Glazkov (Google)
Reported 2011-10-14 11:22:23 PDT
Plumb style-checker filter up to command options and make land-cowboy use it.
Attachments
Patch (7.32 KB, patch)
2011-10-14 11:25 PDT, Dimitri Glazkov (Google) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-10-14 11:25:24 PDT
Created attachment 111032 [details] Patch
Adam Barth
Comment 2 2011-10-14 11:31:14 PDT
Ideally you'd set the option to non-None and check that it's being passed to the style checker appropriately, but you can skip that if you'd prefer.
Adam Barth
Comment 3 2011-10-14 11:31:24 PDT
(I meant in a test, of course)
Dimitri Glazkov (Google)
Comment 4 2011-10-14 11:34:46 PDT
(In reply to comment #3) > (I meant in a test, of course) Oooh, I should totally do this.
David Levin
Comment 5 2011-10-14 11:36:33 PDT
Just curious, why is this being done? (And why omit the changelog checker?)
David Levin
Comment 6 2011-10-14 11:39:27 PDT
(In reply to comment #5) > Just curious, why is this being done? > > (And why omit the changelog checker?) From an answer I got: "It skips changelog check for land-cowboy since it will complain about the missing bug number." ok
Dimitri Glazkov (Google)
Comment 7 2011-10-14 14:11:51 PDT
Committed r97504: <http://trac.webkit.org/changeset/97504>
Note You need to log in before you can comment on or make changes to this bug.