Summary: | Plumb style-checker filter up to command options and make land-cowboy use it. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
Component: | Tools / Tests | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, levin, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 70143 | ||||||
Attachments: |
|
Description
Dimitri Glazkov (Google)
2011-10-14 11:22:23 PDT
Created attachment 111032 [details]
Patch
Ideally you'd set the option to non-None and check that it's being passed to the style checker appropriately, but you can skip that if you'd prefer. (I meant in a test, of course) (In reply to comment #3) > (I meant in a test, of course) Oooh, I should totally do this. Just curious, why is this being done? (And why omit the changelog checker?) (In reply to comment #5) > Just curious, why is this being done? > > (And why omit the changelog checker?) From an answer I got: "It skips changelog check for land-cowboy since it will complain about the missing bug number." ok Committed r97504: <http://trac.webkit.org/changeset/97504> |