Bug 70078 – [EFL] Change the behavior of ewk_view_scale_set.

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Ryuan Choi]

As following Comment$6 of Bug 70004,

I'd like to remove centering code of ewk_view_scale_set to call Page::setPageScaleFactor without any adjustment.
And also, it makes DRT call setPageScaleFactor using this function.

[Ryuan Choi]

Created attachment 110942 [details]
Patch

[Ryuan Choi]

Created attachment 110943 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 110943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110943&action=review

> Tools/ChangeLog:8
> +        Change ewk_view_page_scale which is not merged to ewk_view_scale_set.

I don't understand this description. Do you mean DRT use ewk_view_scale_set instead of  ewk_view_page_scale ?

[Ryuan Choi]

(In reply to comment #3)
> (From update of attachment 110943 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110943&action=review
> 
> > Tools/ChangeLog:8
> > +        Change ewk_view_page_scale which is not merged to ewk_view_scale_set.
> 
> I don't understand this description. Do you mean DRT use ewk_view_scale_set instead of  ewk_view_page_scale ?

Yes. both are doing same thing - calling setPageScaleFactor.
But ewk_view_page_scale is not merged.

So I believe that DRT should use ewk_view_scale_set instead of ewk_view_page_scale.

[Gyuyoung Kim]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 110943 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=110943&action=review
> > 
> > > Tools/ChangeLog:8
> > > +        Change ewk_view_page_scale which is not merged to ewk_view_scale_set.
> > 
> > I don't understand this description. Do you mean DRT use ewk_view_scale_set instead of  ewk_view_page_scale ?
> 
> Yes. both are doing same thing - calling setPageScaleFactor.
> But ewk_view_page_scale is not merged.
> 
> So I believe that DRT should use ewk_view_scale_set instead of ewk_view_page_scale.

I mean you need to modify the description more clear.

[Ryuan Choi]

Created attachment 110949 [details]
Patch

[Ryuan Choi]

(In reply to comment #5)
> 
> I mean you need to modify the description more clear.

OK, I added the comment little bit more.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 110949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110949&action=review

LGTM once you fix these nitpicks of mine.

> Source/WebKit/efl/ChangeLog:9
> +        Remove center point basis zoom alignment from ewk_view_scale_set like WebCore
> +        did.

I didn't understand this part: in what SVN revision did WebCore do what?

> Tools/ChangeLog:10
> +        but ewk_view_page_scale is not merged.

I think it is more clear if you say ewk_page_scale is from a patch that was rejected.

[Ryuan Choi]

Created attachment 111001 [details]
Patch

[Ryuan Choi]

(In reply to comment #8)
> (From update of attachment 110949 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110949&action=review
> 
> LGTM once you fix these nitpicks of mine.
> 
> > Source/WebKit/efl/ChangeLog:9
> > +        Remove center point basis zoom alignment from ewk_view_scale_set like WebCore
> > +        did.
> 
> I didn't understand this part: in what SVN revision did WebCore do what?
> 
> > Tools/ChangeLog:10
> > +        but ewk_view_page_scale is not merged.
> 
> I think it is more clear if you say ewk_page_scale is from a patch that was rejected.

Sorry, changed comment once more.

[Ryuan Choi]

This is out-dated.

[Raphael Kubo da Costa (:rakuco)]

Can you elaborate why?

[Ryuan Choi]

Created attachment 112102 [details]
Patch

[Ryuan Choi]

(In reply to comment #12)
> Can you elaborate why?

Rebased.

I closed as "Resolved later" because I just want to investigate more.
This bug is still valid for me.

I want not to bother you more for this.

Thanks.

[Raphael Kubo da Costa (:rakuco)]

Well, the patch as it stands looks good to me. Do you already have something else in mind which you can share with us?

[Ryuan Choi]

(In reply to comment #15)
> Well, the patch as it stands looks good to me. Do you already have something else in mind which you can share with us?

No. I'll let you know if I have any progress.

[Eric Seidel (no email)]

Comment on attachment 112102 [details]
Patch

OK.  rs=me.

[Ryuan Choi]

Created attachment 119946 [details]
Patch

[Ryuan Choi]

Comment on attachment 119946 [details]
Patch

Thank you, Eric.

[WebKit Review Bot]

Comment on attachment 119946 [details]
Patch

Clearing flags on attachment: 119946

Committed r103288: <http://trac.webkit.org/changeset/103288>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.