Bug 70076 – [chromium] Make it possible for plugins to get current fullscreen element.

• Component: Platform
• Status: RESOLVED FIXED

WebCore::Document already has webkitCurrentFullScreenElement(). Add a wrapper for it in WebKit::WebDocument.

Created attachment 110939 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

Comment on attachment 110939 [details]
Patch

Chromium side patch:
http://codereview.chromium.org/8273029/

[Darin Fisher (:fishd, Google)]

Comment on attachment 110939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110939&action=review

thanks for fixing those style issues!

> Source/WebKit/chromium/public/WebDocument.h:102
> +    WEBKIT_EXPORT WebElement fullScreenElement();

nit: like the other getters, this should be a 'const' method.

> Source/WebKit/chromium/src/WebDocument.cpp:197
> +      return WebElement(fullScreenElement);

nit: should be indented by 4 spaces

Created attachment 110969 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 110969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110969&action=review

> Source/WebKit/chromium/src/WebDocument.cpp:195
> +    Element* fullScreenElement = constUnwrap<Document>()->webkitCurrentFullScreenElement();

I believe the following should work too:

  return WebElement(constUnwrap<Document>()->webkitCurrentFullScreenElement());

It can handle being initialized with a NULL Element.

Created attachment 110972 [details]
Patch

[WebKit Review Bot]

Comment on attachment 110972 [details]
Patch

Clearing flags on attachment: 110972

Committed r97447: <http://trac.webkit.org/changeset/97447>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.