Bug 70053

Summary:

[Qt][WK2] WebErrorsQt.cpp duplicates code from WKError.h and WebError.h

Product:

WebKit

Reporter:

Jesus Sanchez-Palencia <jesus>

Component:

WebKit Qt

Assignee:

Jesus Sanchez-Palencia <jesus>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kenneth

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jesus Sanchez-Palencia 2011-10-13 14:04:05 PDT

We should use the shared error codes enum from Source/WebKit2/Shared/API/c/WKError.h instead of our custom "WebKitError*" codes to keep it aligned with all WebKit2 ports. We should also use WebError::webkitErrorDomain() instead of using a "WebKit" as the error domain for these errors.

Comment 1 Kenneth Rohde Christiansen 2011-10-13 14:06:15 PDT

Sounds good if this is possible

Comment 2 Jesus Sanchez-Palencia 2011-10-13 14:08:32 PDT

Created attachment 110904 [details]
Patch

Comment 3 Jesus Sanchez-Palencia 2011-10-13 14:20:04 PDT

Comment on attachment 110904 [details]
Patch

Clearing flags on attachment: 110904

Committed r97399: <http://trac.webkit.org/changeset/97399>

Comment 4 Jesus Sanchez-Palencia 2011-10-13 14:20:11 PDT

All reviewed patches have been landed.  Closing bug.