Bug 70033

Summary: Web Inspector: move JS specific popover handling to JavaScriptSourceFrame.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+

Pavel Podivilov
Reported 2011-10-13 09:41:57 PDT
Web Inspector: move JS specific popover handling to JavaScriptSourceFrame.
Attachments
Patch (16.51 KB, patch)
2011-10-13 09:43 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-10-13 09:43:36 PDT
Created attachment 110860 [details] Patch
Pavel Feldman
Comment 2 2011-10-16 10:37:21 PDT
Comment on attachment 110860 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110860&action=review > Source/WebCore/inspector/front-end/SourceFrame.js:836 > + shouldShowPopover: function(element) { }, It is not clear what part of extensibility is achieved by means of the delegate versus the abstract methods. You should choose one way of extensibility and stick to it. r- for that.
Pavel Podivilov
Comment 3 2011-10-17 03:48:45 PDT
Extensibility should be achieved by means of the abstract methods. Delegate only serves for eliminating circular dependency between ScriptsPanel and JSSF. Delegate will have just two methods after refactoring: setScriptSourceIsBeingEdited and suggestedFileName. We may even get rid of it completely.
Pavel Feldman
Comment 4 2011-10-17 06:34:57 PDT
Comment on attachment 110860 [details] Patch Ok, I'd like to see delegates gone in the end of this refactoring then.
Pavel Podivilov
Comment 5 2011-10-19 02:47:48 PDT
Committed r97843: <http://trac.webkit.org/changeset/97843>
Note You need to log in before you can comment on or make changes to this bug.