Bug 69991

Summary:

Add regression test: canvas.toDataURL("image/jpeg") should not crash

Product:

WebKit

Reporter:

noel gordon <noel.gordon>

Component:

Tools / Tests

Assignee:

noel gordon <noel.gordon>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, jbauman, kbr, mihaip, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://persistent.info/chromium/test-cases/canvas-crash.html

Bug Depends on:

69681

Bug Blocks:

Attachments:

Description	Flags
Patch	none

noel gordon

Reported 2011-10-12 19:48:14 PDT

Reproduced bug 69681 with the above URL, construct a regression test from it.

Attachments
Patch (1.89 KB, patch) 2011-10-12 19:51 PDT, noel gordon	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

noel gordon

Comment 1 2011-10-12 19:51:36 PDT

Created attachment 110797 [details] Patch

noel gordon

Comment 2 2011-10-12 20:27:15 PDT

mac-ews and cr-mac-ews are a mess at the moment, ... so compiled mac-chrome without http://trac.webkit.org/changeset/97132 and -DWTF_USE_SKIA_ON_MAC_CHROMIUM=0. The patch test case crashes. Added http://trac.webkit.org/changeset/97132 and patch test case passes.

Kenneth Russell

Comment 3 2011-10-12 20:32:11 PDT

Comment on attachment 110797 [details] Patch Very nice. r=me

John Bauman

Comment 4 2011-10-12 20:33:11 PDT

Thanks for doing this. Looks good.

noel gordon

Comment 5 2011-10-12 21:54:57 PDT

No worries. build-webkit --debug at r97243 and the test passes for me. I was unable to reproduce with a webkit nightly (r96471) though.

WebKit Review Bot

Comment 6 2011-10-13 12:24:04 PDT

Comment on attachment 110797 [details] Patch Clearing flags on attachment: 110797 Committed r97382: <http://trac.webkit.org/changeset/97382>

WebKit Review Bot

Comment 7 2011-10-13 12:24:09 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.