Bug 69990

Summary: [nrwt] Add new category for MISSING
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, ojan, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 67268    
Bug Blocks:    
Attachments:
Description Flags
fixes the bug dpranke: review+

Ryosuke Niwa
Reported 2011-10-12 19:18:49 PDT
We shouldn't treat MISSING as flaky. Also we should cleanup summarize_results. It has gotten really big, has many hacks, and is inconsistent with the rest of the codebase.
Attachments
fixes the bug (7.78 KB, patch)
2011-10-17 16:16 PDT, Ryosuke Niwa 		dpranke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-10-17 16:16:19 PDT
Created attachment 111342 [details] fixes the bug
Dirk Pranke
Comment 2 2011-10-17 16:22:10 PDT
Comment on attachment 111342 [details] fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=111342&action=review > Tools/Scripts/webkitpy/layout_tests/port/base.py:725 > + # Don't turn bots red for flaky failures, unexpected passes, and missing results. Nit: Can you add a docstring to this with a more informative explanation of what this routine is doing? (you can probably re-use the comment).
Ryosuke Niwa
Comment 3 2011-10-17 16:41:39 PDT
Committed r97672: <http://trac.webkit.org/changeset/97672>
Ryosuke Niwa
Comment 4 2011-10-18 02:11:12 PDT
Apparently the test was failing :( Fixed it in http://trac.webkit.org/changeset/97730.
Note You need to log in before you can comment on or make changes to this bug.