Summary: | Deprecate event.layerX and event.layerY in WebKit | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Julien Chaffraix <jchaffraix> | ||||||
Component: | UI Events | Assignee: | Julien Chaffraix <jchaffraix> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, dglazkov, mathias, pfeldman, simon.fraser, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 86264 | ||||||||
Bug Blocks: | 21868 | ||||||||
Attachments: |
|
Description
Julien Chaffraix
2011-10-12 12:35:10 PDT
Created attachment 110725 [details]
Proposed change: send a warning to the console and deprecate the properties in the ObjC API.
Comment on attachment 110725 [details] Proposed change: send a warning to the console and deprecate the properties in the ObjC API. Attachment 110725 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10041031 New failing tests: jquery/event.html Created attachment 110787 [details]
Proposed change 2: missed one test to update.
Comment on attachment 110787 [details]
Proposed change 2: missed one test to update.
Seems OK, but doesn’t help us get the data about what sites will be affected. Is there some simple way we can find out?
> Seems OK, but doesn’t help us get the data about what sites will be affected.
> Is there some simple way we can find out?
Chromium has some reporting that we could use. Unfortunately we won't get the individual websites but an aggregate of how much popular the properties are.
Comment on attachment 110787 [details] Proposed change 2: missed one test to update. Clearing flags on attachment: 110787 Committed r97380: <http://trac.webkit.org/changeset/97380> All reviewed patches have been landed. Closing bug. chase.com is one site that calls these a lot. I think we should make these properties non-enumerable at this point. Otherwise, we get this warning every time one iterates over event's properties (or event is expanded in the inspector). (In reply to comment #9) > I think we should make these properties non-enumerable at this point. That seems like a good idea. |