Bug 69951

Summary: Deprecate event.layerX and event.layerY in WebKit
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: UI EventsAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dglazkov, mathias, pfeldman, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 86264    
Bug Blocks: 21868    
Attachments:
Description Flags
Proposed change: send a warning to the console and deprecate the properties in the ObjC API.
none
Proposed change 2: missed one test to update. none

Description Julien Chaffraix 2011-10-12 12:35:10 PDT
Following Sam's comment on bug 21868, the best way to remove event.layerX and event.layerY is to first deprecate them from the ObjC API - the other API don't mind a direct removal - in order to remove them.

As we need to keep the code in WebKit until it is removed from the public API, let's mark it as deprecated so that web-authors are prepared for the removal too.
Comment 1 Julien Chaffraix 2011-10-12 13:00:54 PDT
Created attachment 110725 [details]
Proposed change: send a warning to the console and deprecate the properties in the ObjC API.
Comment 2 WebKit Review Bot 2011-10-12 14:02:22 PDT
Comment on attachment 110725 [details]
Proposed change: send a warning to the console and deprecate the properties in the ObjC API.

Attachment 110725 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10041031

New failing tests:
jquery/event.html
Comment 3 Julien Chaffraix 2011-10-12 18:25:50 PDT
Created attachment 110787 [details]
Proposed change 2: missed one test to update.
Comment 4 Darin Adler 2011-10-13 08:46:40 PDT
Comment on attachment 110787 [details]
Proposed change 2: missed one test to update.

Seems OK, but doesn’t help us get the data about what sites will be affected. Is there some simple way we can find out?
Comment 5 Julien Chaffraix 2011-10-13 11:33:02 PDT
> Seems OK, but doesn’t help us get the data about what sites will be affected.
> Is there some simple way we can find out?

Chromium has some reporting that we could use. Unfortunately we won't get the individual websites but an aggregate of how much popular the properties are.
Comment 6 WebKit Review Bot 2011-10-13 12:06:12 PDT
Comment on attachment 110787 [details]
Proposed change 2: missed one test to update.

Clearing flags on attachment: 110787

Committed r97380: <http://trac.webkit.org/changeset/97380>
Comment 7 WebKit Review Bot 2011-10-13 12:06:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Alexey Proskuryakov 2011-11-03 10:30:46 PDT
chase.com is one site that calls these a lot.
Comment 9 Pavel Feldman 2012-02-02 11:30:28 PST
I think we should make these properties non-enumerable at this point. Otherwise, we get this warning every time one iterates over event's properties (or event is expanded in the inspector).
Comment 10 Darin Adler 2012-02-02 11:49:17 PST
(In reply to comment #9)
> I think we should make these properties non-enumerable at this point.

That seems like a good idea.