Summary: | garden-o-matic should color-code test failure types. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
Component: | Tools / Tests | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 69227 | ||||||
Attachments: |
|
Description
Dimitri Glazkov (Google)
2011-10-12 11:19:04 PDT
Created attachment 110710 [details]
Patch
Comment on attachment 110710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110710&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:205 > + extra blank line > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:210 > + ditto > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:219 > + ol.notifications table.failures tbody tr.IMAGE\+TEXT td:first-child span { It's lame that span here is so unsemantic. Would it be better to use a class instead? I suspect we'll need to iterate on the UI a bit to find the right balance between information and distraction, but we've got to start somewhere. Comment on attachment 110710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110710&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:219 >> + ol.notifications table.failures tbody tr.IMAGE\+TEXT td:first-child span { > > It's lame that span here is so unsemantic. Would it be better to use a class instead? I still need an extra box here. Just adding a class won't help, sadly. (In reply to comment #3) > I suspect we'll need to iterate on the UI a bit to find the right balance between information and distraction, but we've got to start somewhere. Yep. Committed r97281: <http://trac.webkit.org/changeset/97281> |