Bug 69945

Summary: garden-o-matic should color-code test failure types.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: Tools / TestsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 69227    
Attachments:
Description Flags
Patch abarth: review+

Dimitri Glazkov (Google)
Reported 2011-10-12 11:19:04 PDT
garden-o-matic should color-code test failure types.
Attachments
Patch (15.21 KB, patch)
2011-10-12 11:20 PDT, Dimitri Glazkov (Google) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-10-12 11:20:08 PDT
Created attachment 110710 [details] Patch
Adam Barth
Comment 2 2011-10-12 11:32:04 PDT
Comment on attachment 110710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110710&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:205 > + extra blank line > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:210 > + ditto > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:219 > + ol.notifications table.failures tbody tr.IMAGE\+TEXT td:first-child span { It's lame that span here is so unsemantic. Would it be better to use a class instead?
Adam Barth
Comment 3 2011-10-12 11:32:40 PDT
I suspect we'll need to iterate on the UI a bit to find the right balance between information and distraction, but we've got to start somewhere.
Dimitri Glazkov (Google)
Comment 4 2011-10-12 11:34:03 PDT
Comment on attachment 110710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110710&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:219 >> + ol.notifications table.failures tbody tr.IMAGE\+TEXT td:first-child span { > > It's lame that span here is so unsemantic. Would it be better to use a class instead? I still need an extra box here. Just adding a class won't help, sadly.
Dimitri Glazkov (Google)
Comment 5 2011-10-12 11:35:18 PDT
(In reply to comment #3) > I suspect we'll need to iterate on the UI a bit to find the right balance between information and distraction, but we've got to start somewhere. Yep.
Dimitri Glazkov (Google)
Comment 6 2011-10-12 11:45:13 PDT
Committed r97281: <http://trac.webkit.org/changeset/97281>
Note You need to log in before you can comment on or make changes to this bug.