Bug 69943
| Summary: | nwrt: lint-test-files does not seem to work | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> |
| Component: | Tools / Tests | Assignee: | Dimitri Glazkov (Google) <dglazkov> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abarth, dpranke, ossy |
| Priority: | P2 | Keywords: | NRWT |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 64491 | ||
Dimitri Glazkov (Google)
If I run new-run-webkit-tests lint-test-files, I get a bunch of warnings like this:
Exception runnig driver: [u'/Volumes/Work/WebKitForRolls/WebKitBuild/Release/DumpRenderTree', '--print-supported-features'], [Errno 2] No such file or directory. Driver must be built before calling WebKitPort.test_expectations().
Exception runnig driver: [u'/Volumes/Work/WebKitForRolls/WebKitBuild/Release/DumpRenderTree', '--print-supported-features'], [Errno 2] No such file or directory. Driver must be built before calling WebKitPort.test_expectations().
Exception runnig driver: [u'/Volumes/Work/WebKitForRolls/WebKitBuild/Release/DumpRenderTree', '--print-supported-features'], [Errno 2] No such file or directory. Driver must be built before calling WebKitPort.test_expectations().
Exception runnig driver: [u'/Volumes/Work/WebKitForRolls/WebKitBuild/Release/DumpRenderTree', '--print-supported-features'], [Errno 2] No such file or directory. Driver must be built before calling WebKitPort.test_expectations().
Exception runnig driver: [u'/Volumes/Work/WebKitForRolls/WebKitBuild/Release/DumpRenderTree', '--print-supported-features'], [Errno 2] No such file or directory. Driver must be built before calling WebKitPort.test_expectations().
Exception runnig driver: [u'/Volumes/Work/WebKitForRolls/WebKitBuild/Release/DumpRenderTree', '--print-supported-features'], [Errno 2] No such file or directory. Driver must be built before calling WebKitPort.test_expectations().
Exception runnig driver: [u'/Volumes/Work/WebKitForRolls/WebKitBuild/Release/DumpRenderTree', '--print-supported-features'], [Errno 2] No such file or directory. Driver must be built before calling WebKitPort.test_expectations().
Exception runnig driver: [u'/Volumes/Work/WebKitForRolls/WebKitBuild/Release/DumpRenderTree', '--print-supported-features'], [Errno 2] No such file or directory. Driver must be built before calling WebKitPort.test_expectations().
Lint succeeded.
What's more important, it totally missed ambiguous expectations in http://trac.webkit.org/changeset/97271/ and http://trac.webkit.org/changeset/97268/.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Barth
This was a bug caused by some recent Qt changes. I've rolled out the offending change. It should work again.
Adam Barth
Actually, it might be something different.
Dimitri Glazkov (Google)
Ah, it works when you give it the --chromium option, which I don't think is there right behavior.
Dirk Pranke
I think this was fixed long ago; it works fine now.