Bug 69929

Summary:

webkitpy tests are failing on Mac bots

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Tools / Tests

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, eric, levin, simon.fraser, webkit.review.bot

Priority:

Keywords:

MakingBotsRed

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/33843/steps/webkitpy-test/logs/stdio

Attachments:

Description	Flags
Patch	none

Simon Fraser (smfr)

Reported 2011-10-12 08:05:11 PDT

webkitpy failures are contributing to bot redness. Would be good to fix.

Attachments
Patch (2.11 KB, patch) 2011-10-12 11:23 PDT, Adam Barth	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2011-10-12 08:06:11 PDT

Also the debug bot: http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/2541/steps/webkitpy-test/logs/stdio And on Lion: http://build.webkit.org/builders/Lion%20Intel%20Debug%20%28Tests%29/builds/941/steps/webkitpy-test/logs/stdio

David Levin

Comment 2 2011-10-12 09:20:42 PDT

fyi, mostly BaselineOptimizerTest at the moment. abarth is the man for this.

Adam Barth

Comment 3 2011-10-12 09:21:07 PDT

Will fix.

Adam Barth

Comment 4 2011-10-12 11:10:27 PDT

http://trac.webkit.org/changeset/97276

Adam Barth

Comment 5 2011-10-12 11:12:28 PDT

Actually, there's still one more failure on Lion: ====================================================================== FAIL: test_all_test_configurations (webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Volumes/Data/slave/lion-intel-debug-tests/build/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 346, in test_all_test_configurations self.assertTrue(port.test_configuration() in port.all_test_configurations(), "%s not in %s" % (port.test_configuration(), port.all_test_configurations())) AssertionError: <lion, x86, release, cpu> not in [TestConfig(version='leopard', architecture='x86', build_type='debug', graphics_type='cpu'), TestConfig(version='leopard', architecture='x86', build_type='debug', graphics_type='gpu'), TestConfig(version='leopard', architecture='x86', build_type='debug', graphics_type='cpu-cg'), TestConfig(version='leopard', architecture='x86', build_type='debug', graphics_type='gpu-cg'), TestConfig(version='leopard', architecture='x86', build_type='release', graphics_type='cpu'), TestConfig(version='leopard', architecture='x86', build_type='release', graphics_type='gpu'), TestConfig(version='leopard', architecture='x86', build_type='release', graphics_type='cpu-cg'), TestConfig(version='leopard', architecture='x86', build_type='release', graphics_type='gpu-cg'), TestConfig(version='snowleopard', architecture='x86', build_type='debug', graphics_type='cpu'), TestConfig(version='snowleopard', architecture='x86', build_type='debug', graphics_type='gpu'), TestConfig(version='snowleopard', architecture='x86', build_type='debug', graphics_type='cpu-cg'), TestConfig(version='snowleopard', architecture='x86', build_type='debug', graphics_type='gpu-cg'), TestConfig(version='snowleopard', architecture='x86', build_type='release', graphics_type='cpu'), TestConfig(version='snowleopard', architecture='x86', build_type='release', graphics_type='gpu'), TestConfig(version='snowleopard', architecture='x86', build_type='release', graphics_type='cpu-cg'), TestConfig(version='snowleopard', architecture='x86', build_type='release', graphics_type='gpu-cg'), TestConfig(version='xp', architecture='x86', build_type='debug', graphics_type='cpu'), TestConfig(version='xp', architecture='x86', build_type='debug', graphics_type='gpu'), TestConfig(version='xp', architecture='x86', build_type='release', graphics_type='cpu'), TestConfig(version='xp', architecture='x86', build_type='release', graphics_type='gpu'), TestConfig(version='vista', architecture='x86', build_type='debug', graphics_type='cpu'), TestConfig(version='vista', architecture='x86', build_type='debug', graphics_type='gpu'), TestConfig(version='vista', architecture='x86', build_type='release', graphics_type='cpu'), TestConfig(version='vista', architecture='x86', build_type='release', graphics_type='gpu'), TestConfig(version='win7', architecture='x86', build_type='debug', graphics_type='cpu'), TestConfig(version='win7', architecture='x86', build_type='debug', graphics_type='gpu'), TestConfig(version='win7', architecture='x86', build_type='release', graphics_type='cpu'), TestConfig(version='win7', architecture='x86', build_type='release', graphics_type='gpu'), TestConfig(version='lucid', architecture='x86', build_type='debug', graphics_type='cpu'), TestConfig(version='lucid', architecture='x86', build_type='debug', graphics_type='gpu'), TestConfig(version='lucid', architecture='x86', build_type='release', graphics_type='cpu'), TestConfig(version='lucid', architecture='x86', build_type='release', graphics_type='gpu'), TestConfig(version='lucid', architecture='x86_64', build_type='debug', graphics_type='cpu'), TestConfig(version='lucid', architecture='x86_64', build_type='debug', graphics_type='gpu'), TestConfig(version='lucid', architecture='x86_64', build_type='release', graphics_type='cpu'), TestConfig(version='lucid', architecture='x86_64', build_type='release', graphics_type='gpu')]

Adam Barth

Comment 6 2011-10-12 11:23:59 PDT

Created attachment 110711 [details] Patch

Adam Barth

Comment 7 2011-10-12 11:29:25 PDT

Comment on attachment 110711 [details] Patch Clearing flags on attachment: 110711 Committed r97279: <http://trac.webkit.org/changeset/97279>

Adam Barth

Comment 8 2011-10-12 11:29:29 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.