Summary: | DFG JIT 32_64 - Fix ArrayPop | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yuqiang Xian <yuqiang.xian> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | barraclough, fpizlo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Yuqiang Xian
2011-10-12 04:01:10 PDT
Created attachment 110662 [details]
the patch
Created attachment 110672 [details]
the patch
I think I was muddled when developing the previous wrong patch... :(
Also, please help land it manually if you think it should be r+, as I'm not sure if the commit queue will be happy about the style warnings. Thanks a lot.
Attachment 110672 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/assembler/X86Assembler.h:1069: movl_i32m is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Ouch, I can't believe I created that bug. Comment on attachment 110672 [details] the patch Clearing flags on attachment: 110672 Committed r97286: <http://trac.webkit.org/changeset/97286> All reviewed patches have been landed. Closing bug. |