| Summary: | [CSS Regions] Make positioned blocks work with variable width regions. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dglazkov, mihnea, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 57312 | ||||||||
| Attachments: |
|
||||||||
|
Description
Dave Hyatt
2011-10-11 21:21:06 PDT
Created attachment 110634 [details]
Patch
Attachment 110634 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/WebCore/rendering/LayoutState.cpp:97: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/rendering/RenderBox.h:469: The parameter name "region" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 29 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 110634 [details] Patch Attachment 110634 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10031662 Created attachment 110635 [details]
Patch
Fixed in 97282. |