Summary: | REGRESSION(r89915): <input type=email multiple> don't show the default value | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||
Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Major | CC: | morrita | ||||||
Priority: | P1 | Keywords: | Regression | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Kent Tamura
2011-10-11 20:42:04 PDT
Created attachment 110631 [details]
Patch
Comment on attachment 110631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110631&action=review > Source/WebCore/html/EmailInputType.cpp:95 > String EmailInputType::sanitizeValue(const String& proposedValue) I noticed that InptType::sanitizeValue() is virtual and it's indirected by HTMLInputElement::sanitizeValue(). So I hope this kind of guard is inside HTMLInputElement instead each InputType subclasses and allow InputType assume this as a invariant. Also, I hope sanitizeValue() to be const. Created attachment 110642 [details]
Patch 2
Comment on attachment 110631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110631&action=review >> Source/WebCore/html/EmailInputType.cpp:95 >> String EmailInputType::sanitizeValue(const String& proposedValue) > > I noticed that InptType::sanitizeValue() is virtual and it's indirected by HTMLInputElement::sanitizeValue(). > So I hope this kind of guard is inside HTMLInputElement instead each InputType subclasses and > allow InputType assume this as a invariant. > Also, I hope sanitizeValue() to be const. Fixed. Comment on attachment 110642 [details] Patch 2 Clearing flags on attachment: 110642 Committed r97351: <http://trac.webkit.org/changeset/97351> All reviewed patches have been landed. Closing bug. |