Bug 69895

Summary: REGRESSION(r89915): <input type=email multiple> don't show the default value
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Major CC: morrita
Priority: P1 Keywords: Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch 2 none

Comment 1 Kent Tamura 2011-10-11 20:58:53 PDT
Created attachment 110631 [details]
Patch
Comment 2 Hajime Morrita 2011-10-11 22:31:25 PDT
Comment on attachment 110631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110631&action=review

> Source/WebCore/html/EmailInputType.cpp:95
>  String EmailInputType::sanitizeValue(const String& proposedValue)

I noticed that InptType::sanitizeValue() is virtual and it's indirected by HTMLInputElement::sanitizeValue().
So I hope this kind of guard is inside HTMLInputElement instead each InputType subclasses and 
allow InputType assume this as a invariant.
Also, I hope sanitizeValue() to be const.
Comment 3 Kent Tamura 2011-10-11 23:17:39 PDT
Created attachment 110642 [details]
Patch 2
Comment 4 Kent Tamura 2011-10-11 23:18:02 PDT
Comment on attachment 110631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110631&action=review

>> Source/WebCore/html/EmailInputType.cpp:95
>>  String EmailInputType::sanitizeValue(const String& proposedValue)
> 
> I noticed that InptType::sanitizeValue() is virtual and it's indirected by HTMLInputElement::sanitizeValue().
> So I hope this kind of guard is inside HTMLInputElement instead each InputType subclasses and 
> allow InputType assume this as a invariant.
> Also, I hope sanitizeValue() to be const.

Fixed.
Comment 5 Kent Tamura 2011-10-13 00:34:02 PDT
Comment on attachment 110642 [details]
Patch 2

Clearing flags on attachment: 110642

Committed r97351: <http://trac.webkit.org/changeset/97351>
Comment 6 Kent Tamura 2011-10-13 00:34:08 PDT
All reviewed patches have been landed.  Closing bug.